search

3drobotics / ardupilot-solo

GNU General Public License v3.0
137 stars 122 forks source link

Allow operation from a surface with large magnetic anomaly #251

Closed priseborough closed 7 years ago

priseborough commented 7 years ago

This patch allows the compass consistency check to latch to a passed condition if 3 seconds of continuous pass is recorded. This allows the user to clear a failing compass consistency check by picking up the vehicle and putting it down again.

Partially addresses https://3drsolo.atlassian.net/browse/IG-1350

Requires the user to perform an action to clear which requires changes to the app.

ghost commented 7 years ago

Awesome! Two tests I would do:

1) Power Solo up on the BK roof, see it get mag interference, lift it for 3 seconds and put it down and confirm that we can take off safely. 2) Power up Solo on a desk on the BK roof, see it not not get mag interference for 3 seconds, then put it on the metal roof and it should never get mag interference

Additionally, I wonder if we want to play a sound after the mag interference check passes? i.e. you hold solo in the air for 3 seconds and then it plays a happy sound and you know it is OK to put down

blandry commented 7 years ago

@nick3dr are you saying you want to see QA do this or you mean as part of the code review?