search

3dtof / voxelsdk

VoxelSDK - an SDK supporting TI's 3D Time of Flight cameras
BSD 3-Clause "New" or "Revised" License
108 stars 71 forks source link

We should attempt to read from EEPROM only if the board supports it #32

Closed gadiyar closed 9 years ago

gadiyar commented 9 years ago

Right now, except for the TintinCDK, the other boards don't support reading or saving calibration data to EEPROM. Until that support is added, we should avoid attempting to read from the EEPROM for those boards.

(additionally, for VoxelViewer, we need a way to query if there is EEPROM storage capability and provide the option to save to EEPROM only if the hardware supports it)

hlprasu commented 9 years ago

Currently, Voxel SDK does not try read/write if the board does not support. However, the higher layers in SDK, related to serializing/deserializing, are kept common. There might be a stray message in this connection which would be fixed.

Yes, Voxelviewer part needs to be done.

On 17 August 2015 at 16:11, gadiyar notifications@github.com wrote:

Right now, except for the TintinCDK, the other boards don't support reading or saving calibration data to EEPROM. Until that support is added, we should avoid attempting to read from the EEPROM for those boards.

(additionally, for VoxelViewer, we need a way to query if there is EEPROM storage capability and provide the option to save to EEPROM only if the hardware supports it)

— Reply to this email directly or view it on GitHub https://github.com/3dtof/voxelsdk/issues/32.

~ Prasad Bhat

hlprasu commented 9 years ago

Additional point: Voxel SDK currently does full emulation of hardware read/write by storing a local .bin file in .Voxel folder located in user's home directory. Is this useful to retain?

gadiyar commented 9 years ago

Yes, this is probably good to keep for now.

hlprasu commented 9 years ago

Fixed viewer component and changes pushed to devel repos.

On 18 August 2015 at 10:57, gadiyar notifications@github.com wrote:

Yes, this is probably good to keep for now.

— Reply to this email directly or view it on GitHub https://github.com/3dtof/voxelsdk/issues/32#issuecomment-132075047.

~ Prasad Bhat

hlprasu commented 9 years ago

Please confirm whether this issue still exists.

gadiyar commented 9 years ago

Confirmed, this is fixed in current releases by https://github.com/3dtof/voxelsdk/commit/425632df0dcde9d0fc0c63a1381184827ef23e80

Closing.