3fon3fonov / exostriker

Transit and Radial velocity Interactive Fitting tool for Orbital analysis and N-body simulations: The Exo-Striker
MIT License
121 stars 20 forks source link

Removing an inferior planet actually removes the most exterior one #24

Closed 3fon3fonov closed 4 years ago

3fon3fonov commented 5 years ago

Removing an inferior planet actually removes the most exterior one. This is a bug, which needs more time to be resolved but is on my list of things to be done ASAP.

3fon3fonov commented 4 years ago

As a TEMPORARY solution after commit 7aa653b I added es_gui2.py. In this version of the GUI, I solved the issue not very elegantly, but it works... However, so far the hack works ONLY on RV data modeling. To permanently fix this bug I need to re-code some of the classes, functions, variables, and perhaps the Fortran routines. It will probably take a week of work, and thoughtful testing to ensure a stable version release. Help with offline testing will be highly appreciated!

3fon3fonov commented 4 years ago

"es_gui2.py" is now removed, and the default "es_gui.py" is free of this bug. However, if one models RV + transit, or transit only, and removes an inferior planet, it will mix the transit parameters. Thus this bug is still not fully resolved for the transit params.

3fon3fonov commented 4 years ago

This must be fixed now!