Set Status Training page does not reflect current status for selected plan/user/training combination

[michael-milette]

DESCRIPTION

Step 1: Add a Learning Plan

Step 2: Add 2 Trainings, one with a Classroom method and the other with an eLearning method.

Step 3: Assign Both Trainings Into Learning Plan

Step 4: Assign learning plan to user

Step 5: Set Training Status

• Set Learning Plan to "Test Learning Plan"
• Set User to Michael Student (or whatever your student's name is as selected in step 4)
• Set Training to "Training"
• Notice that the status shows "In-Progress". Change this to "Not Yet Started".
• Click the "Save changes" button.
• Notice that Training correctly shows "Test training" and the status correctly shows "Not Yet Started".
• Set the Training field to "Training Test 2".
• Notice that the status shows "Not Yet Started". Change this to "Completed".
• Click the "Save changes" button.
• Notice that the status correctly shows "Completed but the Training shows "Test training" which is incorrect.
• Click on the "Set Training Status" link near the top of the page.
• Notice that training now shows "Test Training" and status correctly shows "In-Progress".
• Change training to "Training Test 2". Notice that Status incorrectly shows "In-Progress".

What I expected is that the selections of a Learning Plan, User and Training would automatically cause Status to change to the displayed setting.

Not only would this change make it more intuitive and easier to use, but, when you click on Setting in the search result, you would see the correct current settings.

Continuing with the scenario above, we can demonstrate this by clicking on the Learning Plan "Search" link. Set the search fields as follows:

• Learning Plan: Test Learning Plan
• Training: Test Training
• Status: Not Yet Started

Now click the "Search" button.

From the search results, notice that the first Status column correctly shows "Not Yet Started." for the Test Training row. Now click on the "Setting" link in the second Status column.

Now I have to interrupt here to comment about the fact that there are 2 columns both called "Status". My recommendation would be to change the name of the last column to "Setting" and change the "Setting" link label to "Edit" or "Modify". Now back to our scenario.

Now click "Setting" in the last column.

Notice that the status on the Set Training Status page is not "Not Yet Stated" but "In-Progress. If I were to assume that the information is current in the form and click the "Save Changes" button at this point, I could very well inadvertently change the status without realizing it.

I realize some people will say "don't click save!" but the fact of the matter is that people will do it anyway. The alternative would be to display a message on the page indicating that the displayed information may not accurately reflect the current status of a user.

ENVIRONMENT

Moodle 2.7.11+ and Learning Plan version 2014082003.

Let me know if you have any questions.

Best regards,

Michael

[michael-milette]

Just had an idea... Instead of having a separate column for the status link (last column), why not just eliminate that column completely and make the actual status in the Status column clickable. Not only would that resolve the problem but it will give you more space for the other columns.

[3ilogiclms]

Dear Michael,

Thank you for providing ideas and and identify existing fixes in learning plan code in Github. We've updated code in Github now with our latest changes as we've done majority of these fixes earlier but didn't update here, now you can use our latest code and identify issues in new code and we're thank full to you for assisting our development team for plugin fixes.

Regards, 3i Logic LMS Team.

[michael-milette]

Thank you for fixing the issue with the status column. Changing the heading to Setting and the link to Modify is acceptable as seen in version 2014082003 of the plugin that I downloaded yesterday from GitHub.

However the issue of the status within the form not actually refecting the current status for the selected plan/user/training combination is still an issue.

Please let me know when this has been addressed and I will be happy to test it again for you and report any further issues.

Best regards,

Michael

[3ilogiclms]

Dear Michael,

Thank you for your response and we'll get back to you after some evaluation.

Regards, 3i Logic LMS Team