Make cherrys work with modern redis and cherrypy version

3kwa / cherrys

Redis backend for CherryPy sessions

21 stars 7 forks source link

Make cherrys work with modern redis and cherrypy version #4

Closed ralhei closed 1 year ago

ralhei commented 1 year ago

Hi Eugene, hope you accept this pull request to your really cool cherrypy redis-session package. The main changes are:

Upgraded to Python 3 (only)
Adapted you relatively up-to-date redis and cherrypy versions
Support distributed session locking via redis locks
Switched to pytest testing (cause cherrypy does the same)
Support redis-url for connecting to redis server
Setup sensible default values for optional connection parameters.
Some code reformatting to fit pep8/flake8 styling requirements
Updated documentation

I'm happy to discuss details. Ralph

3kwa commented 1 year ago

Thanks @ralhei - will switch to calendar versioning and release later this week

ralhei commented 1 year ago

Thanks for accepting this pull request. Just out of curiosity ... what is your background motivation for switching to calver? I've looked it up in calver.org, there is a section at the end of the readme telling for which project types this makes most sense ... here cherrys doesn't quite fall into this category... so I was wondering what kind of advantages you would see there ...

3kwa commented 1 year ago

I find it very convenient to be able to get from the version when it was published hence have been using it for more recent packages I published

ralhei commented 1 year ago

This makes sense. However, the only expressive power that I'm missing from caldev is when you make massive, possibly backward-incompatible changes, there is no way to express that through versioning. With semver I would e.g. then change the version number from '3.6.1' to '4.0.0' to express a bigger change. With calver you would just upgrade from e.g. '2023.2.1' to '2023.3.0' which doesn't inform IMO the user of such a change.