search

3liz / QgisQuickExportPlugin

3 stars 3 forks source link

port to QGIS3 #14

Closed AlisterH closed 4 years ago

AlisterH commented 4 years ago

Port to QGIS3; it could be cleaned up a little.

mdouchin commented 4 years ago

Thanks a lot @AlisterH for your work. Please ping us when you decide we should merge your PR.

AlisterH commented 4 years ago

Hi, I would merge it now. It seems to be all working on 3.x, the only issue is that when outputting to printer the text is vectorised (not rasterised as I mistakenly said in a commit message). This must be a problem with Qt5 or QtWebkit; I tried to look into it, but didn't get anywhere. It would need more work if you wanted it to still work in 2.x, otherwise ideally all the code that was to support older versions could be cleaned out.

Gustry commented 4 years ago

Hi,

Thanks for this work.

It would need more work if you wanted it to still work in 2.x, otherwise ideally all the code that was to support older versions could be cleaned out.

The QGIS minimum version in the metadata.txt has been raised to 3.0, so it's fine to remove old code. I saw you kept some code for 1.8. Feel free to remove it if you want, but it's not compulsory ;-) I will review tomorrow the other part.

Gustry commented 4 years ago

@AlisterH How do you feel about this PR? Is-it ready for a review?

AlisterH commented 4 years ago

Yes please - I'm not doing anything else to it.

Gustry commented 4 years ago

Ok, I will take of the plugin for QGIS 3 now. Thanks!