3liz / QuickOSM

QGIS plugin to fetch OSM data with the Overpass API
GNU General Public License v2.0
188 stars 55 forks source link

Modeler output without specified output #362

Open dingausmwald opened 3 years ago

dingausmwald commented 3 years ago

The "osm data from a raw query" algorithm in the modeler outputs layers even when they are not linked to an output. Is this normal? Tested with qgis 3.16 and 3.20

Gustry commented 3 years ago

Can you share a screenshot or can you explain what do you mean by "not linked to an output" ?

dingausmwald commented 3 years ago

Hey. Ofc, thanks for the fast response.

For v.clean f.e. there is only a temporary layer output if you set names for the outputs (moreover, there is a extra output field for cleaned and errors). If not, the algorithm writes to a temporary file. image

The osm raw query algorithm 1. has no further output fields for the outputs (file, points, lines, multilinestrings and multipolygons) but second, doesn't matter if you set a output name or not, there is always a temporary layer export. image

dingausmwald commented 3 years ago

Well, i removed

                context.addLayerToLoadOnCompletion(
                    layers[layer]['vector_layer'].id(),
                    layer_details
                )

from quickosm_process.py and this did the trick for me. I can still process the output in the modeler when referring to the algorithm output " "output lines" from algorithm "Download OSM data from raw query" " f.e.. No automatic temporary layer output anymore.

Gustry commented 3 years ago

Ah yes indeed. It seems logical. I will try to have a look soon. Thanks for checking in the code ...

kannes commented 2 years ago

I just ran into this too. It would make using QuickOSM in modeller workflows much nicer in cases where intermediate data is not really needed in the end.

pathmapper commented 2 years ago

We are also running into this.

Additionally to the not needed/wanted output, depending on the features (if they hold a colour-key/value) there is also a somehow confusing error raised when running a model with the Download OSM data from a raw query-algorithm, because QuickOSM fails to style the unwanted output:

Sample model: raw_query.zip

grafik

grafik

grafik

Raw query:

[out:xml] [timeout:2500];
{{geocodeArea:Kreis Viersen}} -> .area_0;
(
    nwr["amenity"="public_bookcase"](area.area_0);

);
(._;>;);
out body meta;