3liz / QuickOSM

QGIS plugin to fetch OSM data with the Overpass API

GNU General Public License v2.0

180 stars 54 forks source link

Algorithm "Download OSM data from a raw query" not available in processing modeler #474

Open pathmapper opened 10 months ago

pathmapper commented 10 months ago

What is the bug?

Algorithm "Download OSM data from a raw query" not available in processing modeler anymore, only the algs under Advanced are available.

This is because of https://github.com/3liz/QuickOSM/blob/ad57bc8c724ed8364fef3ccca0dc05856c0f9d98/QuickOSM/quick_osm_processing/quickosm_process.py#L81 is this expected?

I think this alg was available in the past because I've got some old models using it :-)

grafik

Environment

QuickOSM version: 2.2.3
QGIS version: 3.30.2
OS: Windows 10

Gustry commented 10 months ago

Hum, I will look into it.

git blame tells me it likes this for at least 2 years minimum (July 2021). (creation of the file, but maybe it was legacy from a previous implementation)

But this algorithm "Download OSM data from raw query", isn't it two algorithm "Build raw query" and then send the output the native "native:filedownloader" algorithm ?

So, a long time ago... I will try to remember.

pathmapper commented 10 months ago

Thanks for looking into it @Gustry

Motivation to have it again available in the processing modeler:

easier to use and explain (no need to use native:filedownloader afterwards)
attribute value encoding is correct - with "Build raw query" + native:filedownloader I'm running into https://github.com/3liz/QuickOSM/issues/369
hstore field "other tags" seems already exploded
all in all same result as when using a raw query from plugin interface

pathmapper commented 10 months ago

Maybe the reason not to show it were the side effects described in https://github.com/3liz/QuickOSM/issues/362.

But can't spot anything in the changelog about the removal, so maybe it was unintentional.

Gustry commented 10 months ago

362 is from october 2021, git blame is at minimum July 2021. I will dig what has been done.

hstore field "other tags" seems already exploded

Indeed, it was like a package all inclusive : building query, encoding it, calling the native file download, then extracting data

I haven't been using QuickOSM for years now, so I don't remember the reason of the flag.