Adding PhpStan - Githubissues

pdrillin commented 3 years ago

Ticket : fixes #9

Gustry commented 3 years ago

I'm wondering what would we the best strategy for such analysis. These errors are here because it's missing the parent project Lizmap.

Add on the exclude list these "upstream objects", but I think we are going to miss the main reason of this analysis, checking members, properties etc ...
Adding Lizmap as required in the composer.json?
Launching in a lizmap docker image ?
Other options?

@drillinP Can you launch phpstan locally, where you have Lizmap installed, these errors should go away, right ? (and maybe real errors will occur)

Gustry commented 3 years ago

@drillinP Gentle ping for the discussion above, can you add what you tried what as working/not working ? Thanks

pdrillin commented 3 years ago

@Gustry I have launch phpstan locally with lizmap and i have same errors

pdrillin commented 3 years ago

@Gustry I think that it is necessary to define the variables coming from other projects upstream in a config file to be able to use phpstan correctly, but this file can become very long.

3liz / lizmap-pgmetadata-module

Adding PhpStan #10