search

3liz / lizmap-pgmetadata-module

PgMetadata Lizmap module
https://github.com/3liz/qgis-pgmetadata-plugin
0 stars 5 forks source link

Enable and fix Eslint checks on GitHub Actions #4

Closed Gustry closed 3 years ago

Gustry commented 3 years ago

@nboisteault What do you think ?

The unused variable uncheck seems verbose to me. Isn't there another way ?

Then for others, I'm not sure if it was not false positive error or not.

nboisteault commented 3 years ago

@Gustry @drillinP : this JS code will change a lot and we'll take care of unused variable.

Gustry commented 3 years ago

Do you mean we merge this PR and we give it a try ? @nboisteault

If it's too much, we can review the config in a few days.

nboisteault commented 3 years ago

I thunk you can merge all but pgmetadata.js

Gustry commented 3 years ago

Ok, I have removed my changes on pgmetadata.js. Now, the CI is failing. @drillinP You would need to rebase your PR and include fixes about EsLint.