3liz / lizmap-pgrouting-module

PgRouting module for Lizmap
https://docs.3liz.org/lizmap-pgrouting-module/
6 stars 8 forks source link

Question: what is the role of the "edition" table in the "pgrouting_demo" schema? #48

Open gioman opened 4 months ago

gioman commented 4 months ago

As part of the installation/configuration it is created also a "pgrouting_demo" schema, with a "edition" table in it.

This table is part of the sample projects here

https://demo.lizmap.com/lizmap/index.php/view/media/getMedia?repository=modules&project=pgrouting&path=/media/pgrouting.zip

and here

https://github.com/3liz/lizmap-pgrouting-module/tree/master/tests/lizmap/instances/pgrouting

anyway is unclear its function, as I can't see any mention in docs, and also I can't see any change in the table content when/after using lizmap/pgrouting.

Bonus question 1: what is the function of the JS file in media/js/pgrouting? is it mandatory? why its content is different here

https://demo.lizmap.com/lizmap/index.php/view/media/getMedia?repository=modules&project=pgrouting&path=/media/pgrouting.zip

and here

https://github.com/3liz/lizmap-pgrouting-module/tree/master/tests/lizmap/instances/pgrouting/media/js/pgrouting

?

Bonus question 2: what is the function of the "qgis_plugin" table also created inside the "pg_routing" schema?

Gustry commented 4 months ago

The edition table is for dev purpose I would say, it's to show the "copy geometry" feature. In LWC core, we can "paste" the geometry. I could be for a demo, but it's very specific and hidden. It shouldn't be presented like that I guess in the docs.

Bonus question 1

The JS in the demo ZIP is just to open the PGRouting panel, so it's easier for a demo, the page is ready with PGRouting enabled.

The JS in the tests folder is for testing purpose, not needed.

Bonus question 2:

The table qgis_plugin is used in many modules we have, for instance PgMetadata. But indeed, this can be safely removed for now from PgRoutring module because there isn't any QGIS plugin associated for now with this module.

gioman commented 4 months ago

Thanks!

Gustry commented 4 months ago

I will keep this ticket open as a reminder, not sure when. Linked to #47 as well