Add a panel with project misconfigurations & optimisation suggestions

3liz / lizmap-plugin

Lizmap plugin for QGIS, allowing to publish QGIS maps to Lizmap Web Client

https://www.lizmap.com/

GNU General Public License v2.0

61 stars 30 forks source link

Add a panel with project misconfigurations & optimisation suggestions #389

Open mdouchin opened 2 years ago

mdouchin commented 2 years ago

We have a list of long well-known possible misconfigurations in a Lizmap project:

[x] PostgreSQL layers without a password (or better a service file)
[x] No integer primary keys
[x] int8 primary keys https://github.com/3liz/lizmap-plugin/commit/39a6798b55894377e950951718ea5b9386ac63eb
[ ] Layer not published as WFS -> do it for the user
[x] Identifier field not published as WFS
[x] Local datasource (C:/ , etc.)
...

Or pieces of advice to improve performances or "user-friendlyship"

[ ] Check the "Add the geometry to WMS GetFeatureInfo response"
[x] Use the "Trust" project option
[ ] Use JPEG format for the base layers and for the layers with no need for transparency
[ ] Use png; mode=16bit or png; mode=8bit when there is few colors in style
[ ] Check Use estimated table metadata when creating connexion
...

It could be great to list these things and warn the user with a of changes to make.

mdouchin commented 2 years ago

cc @rldhont @nboisteault

Gustry commented 2 years ago

[ ] According to the discussion today for LWC 3.6 : check the layer ID for as name
[ ] Check fields used in all table manager if they are still in WMS/WFS
[x] Do not use bigint primary key : https://github.com/3liz/lizmap-plugin/commit/39a6798b55894377e950951718ea5b9386ac63eb
[ ] geometry not included on the server side, while some expressions are using it, easiest is display name
[ ] Any layer with a "qgis auth manager" set up (already done for vectors), IGN raster with basic auth
[ ] A layer is not "queryable" in the project properties, "datasource tab" while the popup is enabled

Gustry commented 1 year ago

List of current QMessageBox used, because of a project check :

Address search without a key : IGN&google. By the way, this really something to fix after bbd67e1678b348ae0e9ba4cc61e885676f3ce348
"Use layer IDs as name" since LWC 3.6, blocking the saving
SAAS
- ECW
- Auth DB for postgresql
- Path higher than ../../
Invalid field type tid, int8 ...
Duplicated layer with filters
Legend image 3.6
Deprecated lizmap popup for all versions
Legacy server without admin user, LWC 3.5 etc
Legacy server not providing a correct metadata, the plugin on the server side was not required before 3.6
Accent, space ... in project name (this has been fixed in latest LWC releases, need to check)
Capitalize layer names
Absolute path in project properties

Gustry commented 5 months ago

[ ] In #564 we were thinking to check rasters having a authcfg as well. It has been done only for French IGN provider for now to have an explicit error message. We can extend with generic layers as well.

nboisteault commented 4 months ago

[ ] warn users when using jp2 files and propose a conversion to tiled GeoTiff, compressed to jpeg with pyramids
[ ] warn users about heavy jpg, png, svg files in print composer

nboisteault commented 4 months ago

[ ] suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

Gustry commented 4 months ago

@nboisteault We are trying to make the list objective :)

warn users about heavy jpg, png, svg files in print composer

What is heavy ? :)

suggest server cache for not editable layers and no specific rights

This is IMHO very project specific. For now, we can't make "suggestion", as all "errors" are reported in the CFG file and then displayed in LWC when connected as an admin, so we must stay objective.

Gustry commented 4 months ago

suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

See the issue https://github.com/3liz/lizmap-web-client/issues/4327 The cache can lead to other side effect and not necessary for all layers.

nboisteault commented 4 months ago

@nboisteault We are trying to make the list objective :)

warn users about heavy jpg, png, svg files in print composer

What is heavy ? :)

I don't know ;)

suggest server cache for not editable layers and no specific rights

This is IMHO very project specific. For now, we can't make "suggestion", as all "errors" are reported in the CFG file and then displayed in LWC when connected as an admin, so we must stay objective.

So let's not write it in cfg :)

nboisteault commented 4 months ago

suggest server cache for not editable layers and no specific rights. We could save a lot of GetMap requests.

See the issue 3liz/lizmap-web-client#4327 The cache can lead to other side effect and not necessary for all layers.

I'll fix this one.