3liz / lizmap-web-client

Transfer a QGIS project on a server, Lizmap is providing the web interface to browse it
https://www.lizmap.com
Mozilla Public License 2.0
252 stars 141 forks source link

Remove code related to Stamen tiles #3914

Open Gustry opened 10 months ago

Gustry commented 10 months ago

Related to warnings displayed in Stamen tiles, this provider will stop on October 2023 : https://demo.lizmap.com/lizmap/index.php/view/map?repository=features&project=fire_hydrant_actions

As in 3.7, we don't manage base layers anymore, this code can be removed I think in 3.7.

gioman commented 10 months ago

@Gustry

As in 3.7, we don't manage base layers anymore

I've seen some message about this change, which make sense (not printable, not possible to reproject them, etc.) anyway they had the advantage to be much faster to load than any other remote baselayer such a wms or a xyz ones (even with tiling). There will be any new mechanism to compensate for that?

Gustry commented 10 months ago

There will be any new mechanism to compensate for that?

You can already try, go in the "Baselayers" tab of your plugin, and click "OpenStreetmap", that's it ;-)

Like https://demo.snap.lizmap.com/lizmap_3_7/index.php/view/map?repository=testsrepository&project=base_layers_user_defined#

Gustry commented 10 months ago

See https://stamen.com/faq

Commit in the plugin https://github.com/3liz/lizmap-plugin/commit/2bf8ca2656d7b13650c8e5205f3acea0367b7058

gioman commented 10 months ago

You can already try, go in the "Baselayers" tab of your plugin, and click "OpenStreetmap", that's it ;-)

Like https://demo.snap.lizmap.com/lizmap_3_7/index.php/view/map?repository=testsrepository&project=base_layers_user_defined#

@Gustry thanks, I have probably misunderstood what the implications of what you mean for "we don't manage base layers anymore" so I will test lizmap 3.7 before commenting any further :)

Gustry commented 8 months ago

Some code about Stamen has been removed in #4007

Gustry commented 7 months ago

I think most code removal will be when LWC target version is for 3.7