3liz / lizmap-web-client

Transfer a QGIS project on a server, Lizmap is providing the web interface to browse it
https://www.lizmap.com
Mozilla Public License 2.0
259 stars 143 forks source link

field not null (edit widget photo/file name) - wrong error message if it is empty #572

Closed josemvm closed 2 years ago

josemvm commented 7 years ago

if the photo field is empty, the message should be this:

field

not this general: error

thanks

josemvm commented 7 years ago

some behavior for date widget

rldhont commented 5 years ago

@josemvm can you test https://github.com/3liz/lizmap-web-client/pull/1111 or actual release_3_2 branch ?

josemvm commented 5 years ago

hi @rldhont , the problem remains

laurentj commented 5 years ago

I tried to fix the current code, but it is complicated to modify it to fix this bug, because of some limitation of jForms (the form component of Jelix). It is better to encapsulate all the logic of the upload field into a jForms plugin, to benefit of the feature of jForms, and so to avoid kind of bugs like this.

Hopefully, a plugin implementing the logic of the current code of upload, has been added to Jelix recently. We should use it and replace all "home made" code for upload. But I prefer to do this replacement into a non-stable version (3.3), to avoid regression in the 3.2 version.

laurentj commented 2 years ago

fixed.