3liz / qgis-pgmetadata-plugin

QGIS Plugin to manage some metadata from PostgreSQL layer
GNU General Public License v2.0
12 stars 10 forks source link

Glossary: additional publication frequencies, incl. item_order #103

Closed effjot closed 8 months ago

effjot commented 2 years ago

Now all publication frequency terms from ISO 19115 are implemented and translated to German: https://www.geoportal-bw.de/documents/20147/754293/ISO_19115_Deutsch_Stand_08-12-2008.pdf table „B.5.18 MD_MaintenanceFrequencyCode“

I’ve set the version to 1.2.0 and introduced a file upgrade_to_1.2.0.sql.

effjot commented 2 years ago

By the way, is there way to use the item order in the attribute forms?

Gustry commented 2 years ago

By the way, is there way to use the item order in the attribute forms?

I think there is a checkbox "Order by value" in the field form settings.

effjot commented 2 years ago

By the way, is there way to use the item order in the attribute forms?

I think there is a checkbox "Order by value" in the field form settings.

That would sort alphabetically according to the label_xx field (i.e. the values shown in the dropdown list). Unless it is well hidden, there doesn’t seem to be an option for a separate sort key.

effjot commented 2 years ago

I have changed the glossary terms introduced in this PR to begin with upper case letters.

@Gustry Should I extend upgrade_to_1.2.0.sql and 90_Glossary.sql so that the existing terms (introduced before this PR) are corrected, too? Or would you prefer this in a separate PR?

effjot commented 2 years ago

@Gustry Github says “This branch has conflicts that must be resolved” for upgrade_to_1.2.0.sql. I think I need to rebase on upstream/master, correct?

Also, should I change case for existing terms (introduced before this PR) here, too?

effjot commented 2 years ago

While we’re working on this PR, I’ve found 2 more additions to the glossary lying around in our local installation:

INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'directory', 'A directory', 'Directory on the local filesystem', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'Ein Ordner', 'Ein Ordner auf dem lokalen Dateisystem');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en) VALUES ('link.mime', 'directory', 'inode/directory', 'Directory (not an official MIME type');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'ESRI:SHP', 'ESRI Shapefile', 'Vector layer in Shapefile format (.shp)', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'ESRI Shapefile', 'Vektorlayer im Shapefile-Format (.shp)');
effjot commented 2 years ago

While we’re working on this PR, I’ve found 2 more additions to the glossary lying around in our local installation:

  • file/link type for a directory (We use it to point to a folder on our fileserver containing additional documentation, e.g. legends, descriptions of data by the provider.)
  • file/link type for ESRI Shapefiles (still very common distribution format; we store a link to the original download source)

Should I add these to the PR?

effjot commented 2 years ago

I’ve rebased the glossary additions in the original PR onto version 1.2.1 and added the suggestions for 2 new link types in a new commit.

effjot commented 1 year ago

Is there any work for me to do on this PR? Thanks!

effjot commented 1 year ago

Is this PR ready for merging? @Gustry @mdouchin

I could also add the glossary items in #152.

effjot commented 1 year ago

I have extended this PR to include @mixedbredie’s suggestions from #152 (with German translations from the INSPIRE website) and the “unknown“ terms I have proposed in #159. Also, there are some more roles and frequencies we’ve encountered and would suggest as an addition to the glossary.

@Gustry and @mdouchin: could this PR be merged? Thank you!

effjot commented 1 year ago

Just a little ping if this PR could be merged. ;-) @Gustry @mdouchin

Gustry commented 11 months ago

I will have a look next week, very sorry for the delay !

effjot commented 11 months ago

Thank you!

effjot commented 9 months ago

Could you decide whether to merge this PR? Thanks!

Gustry commented 9 months ago

As you are adding new features, we will make a 1.3.0 version. Can you switch to this migration file ?

effjot commented 9 months ago

Thanks! I’ll have a look into the migration files soon.

effjot commented 8 months ago

Great, thanks!

effjot commented 8 months ago

Maybe you could add French translations for the new glossary terms before releasing the new version? I can’t speak French and I dare not use Google translate. ;-)

Gustry commented 8 months ago

Yes, I was planning to do that before releasing the new version. I guess you want to update/rebase #85 so we avoid having conflict together ;-)