search

3liz / qgis-veloroutes_voies_vertes-plugin

Standard Covadis Véloroutes et Voies Vertes (3V)
4 stars 5 forks source link

Action: Delete elements from segments #72

Closed pdrillin closed 3 years ago

pdrillin commented 3 years ago

Description

rldhont commented 3 years ago

LGTM, waiting for @Gustry before merging

Gustry commented 3 years ago

Je pense que un rebase sera possible après le merge de #71 et on peut ainsi supprimer du code dupliqué entre les 2 PR. Keep it DRY https://en.wikipedia.org/wiki/Don't_repeat_yourself ;-)

rldhont commented 3 years ago

@drillinP pour remove_selected_portion et remove_selected_segment on pourrait créer une méthode commune

def remove_selected_from_relation(agg_id: int, agg_primary_key: str, src_layer_name: str, src_primary_key: str, rel_layer_name: str):
    pass

Utilisable ainsi

def remove_selected_portion(*args):
    remove_selected_from_relation(int(args[0]), 'id_itineraire', 'v_portion', 'id_portion', 'etape')

def remove_selected_segment(*args):
    remove_selected_from_relation(int(args[0]), 'id_portion', 'segment', 'id_segment', 'element')

@Gustry un avis ?

Gustry commented 3 years ago

@Gustry un avis ?

+1 aussi pour DRY (Don't Repeat Yourself) instead of WET (Write Everything Twice) :D

remove_selected_from_relation -> _remove_selected_from_relation pour montrer que c'est un peu un méthode interne, privée au fichier actions.py

pdrillin commented 3 years ago

@rldhont @Gustry C'est bon pour vous ?

pdrillin commented 3 years ago

@Gustry je merge ?