search

3lvis / DATASource

Core Data's NSFetchedResultsController wrapper for UITableView and UICollectionView
Other
106 stars 27 forks source link

Add configuration of animations with convenience constructor #63

Closed zarv1k closed 8 years ago

zarv1k commented 8 years ago

In my project using DATASource I want to have ability to configure row animations. It would be great that DATASource will support the feature.

zarv1k commented 8 years ago

Changed constructor

3lvis commented 8 years ago

Hi @zarv1k,

Nice addition! I think this could be done as a parameter instead of having it in the initalizer though.

zarv1k commented 8 years ago

@3lvis, Animations configuration dictionary is optional public property. Should I change anything else in addition to remove of my convenience initializer for merge this PR?

3lvis commented 8 years ago

@zarv1k I'll remove the convenience :) Thanks for this addition 👏

3lvis commented 8 years ago

Shipped, thanks!

https://github.com/3lvis/DATASource/releases/tag/5.7.0

zarv1k commented 8 years ago

@3lvis, thank you for awesome library and your fast feedback ;)

3lvis commented 8 years ago

Thank god I disabled this thing.