search

3lvis / Networking

Swift HTTP Networking with stubbing and caching support
MIT License
1.36k stars 112 forks source link

Enum rename #254

Closed 3lvis closed 4 years ago

mkll commented 4 years ago

@3lvis Good example of problem resolving:

  1. Detect a problem
  2. Wait half year
  3. Close the PR
  4. No PR — no problem :)

PROFIT!

3lvis commented 4 years ago

Hello Alex! Haven’t had more people pointing this was an issue for them and it’s quite an abrupt change to make. I’m sorry I didn’t communicate this more clearly before. Running an open source project means making a lot of compromises and unless this is a wide problem I would prefer to reduce the amount of breaking changes.

mkll commented 4 years ago

@3lvis Result is in Swift standard library since Swift 5. It's very common type and recommended "swifty" way to return values in opposite to classic ObjC way. You just invented it early than it was introduced in Swift. Do you really think that such a common thing will not conflict with Swift standard type forever? Well, this is up to you, but it looks strange.

mkll commented 4 years ago

You say no one had a problem? So maybe they are not using Result.

For example, I rarely use UInt16, and if someone “invented” it in their library, I would not have problems, I would not even know about it. But does this mean that using type names that conflict with the standard library is good practice?

3lvis commented 4 years ago

I'm revisiting the PR, doesn't seem like it would cause any breaking changes :) https://github.com/3lvis/Networking/pull/259

mkll commented 4 years ago

@3lvis I think so too. :) Thanks!

3lvis commented 4 years ago

Released as 5.0.2, thank you!

https://github.com/3lvis/Networking/releases/tag/5.0.2

mkll commented 4 years ago

@3lvis Thank you for the great library!