wessel-novacustom commented 1 year ago

The problem you're addressing (if any)

The chip GD25Q256D - found on some NovaCustom NV4-ADL devices - doesn't work on RTE, while it does work with the CH341A programmer.

Describe the solution you'd like

The chip GD25Q256D to be supported by RTE, so that our devices with this chip can be flashed with RTE.

Where is the value to a user, and who might that user be?

Especially for internal use, but it might also be useful for other RTE users.

Describe alternatives you've considered

CH341A programming, which works, but is about 4 times slower than RTE.

Additional context

The read command was successful, while the write command was not. Log after the write command:

set SPI Vcc to 3.3V SPI lines ON SPI Vcc ON Writing ... flashrom v1.2 on Linux 5.4.69 (armv7l) flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Found GigaDevice flash chip "GD25Q256D" (32768 kB, SPI) on linux_spi.

This flash part has status UNTESTED for operations: PROBE READ ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom@flashrom.org if any of the above operations work correctly for you with this flash chip. Please include the flashrom log file for all operations you tested (see the man page for details), and mention which mainboard or programmer you tested in the subject line. Thanks for your help! Reading old flash chip contents... done. Erasing and writing flash chip... Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. Looking for another erase function. Reading current flash chip contents... done. No usable erase functions left. Reading current flash chip contents... done. SPI Vcc OFF SPI lines OFF

PLangowski commented 11 months ago

@wessel-novacustom Hi, it has been a while since you raised this issue. Is it still relevant? If so, we can look into the problem.

wessel-novacustom commented 11 months ago

Yes it is.

macpijan commented 11 months ago

We can list which chips are supported for given flashrom revision using: flashrom --list-supported.

If it is in fact not there, we may check in the upstream flashrom if such chip has been added, and update our recipe. If it is not there either, we must add it to the upstream flashrom first.

wessel-novacustom commented 11 months ago

@macpijan

Please make sure that the following chips are supported by the RTE:

W25Q256.V
MX25L25635F/MX25L25645G
GD25Q256D

We can do the testing, no problem.

Thanks.

PLangowski commented 11 months ago

@macpijan Currently RTE has flashrom version 1.2.1.

# flashrom -L
flashrom v1.2 on Linux 5.4.69 (armv7l)
flashrom is free software, get the source code at https://flashrom.org

Supported flash chips (total: 538):

Vendor        Device                 Test  Known   Size   Type      
                                     OK    Broken  [kB]             

(P = PROBE, R = READ, E = ERASE, W = WRITE, - = N/A)
(...)
GigaDevice    GD25Q256D                            32768  SPI       =
Macronix      MX25L25635F/           PREW          32768  SPI       
              MX25L25645G
Winbond       W25Q256.V              PREW          32768  SPI

Which means that GD25Q256D has not been tested. I checked the support on v1.3.0:

GigaDevice                   GD25Q256D/                           PREW          32768  SPI   
Macronix                     MX25L25635F/                         PREW          32768  SPI       
                             MX25L25645G
Winbond                      W25Q256FV                            PREW          32768  SPI       
Winbond                      W25Q256JV_Q                                        32768  SPI       
Winbond                      W25Q256JV_M                          PREW          32768  SPI       
Winbond                      W25Q256JW                            PREW          32768  SPI       
Winbond                      W25Q256JW_DTR                        PREW          32768  SPI

It seems that updating our layer to include flashrom v1.3.0 will solve our problem regarding GD25Q256D. I'm not sure about W25Q256.V though.

wessel-novacustom commented 11 months ago

Would be great if it can be updated. If it has been done, please let me know.

PLangowski commented 11 months ago

@wessel-novacustom Hi, we just published a pre-release, which tackles this issue by updating flashrom to v1.3.0. Could you test if it works properly?

wessel-novacustom commented 11 months ago

I will do so soon and let you know, thank you.

PLangowski commented 10 months ago

@wessel-novacustom Did you manage to test the update yet?