search

3mdeb / meta-rte

Yocto meta layer for the RTE https://3mdeb.com/products/open-source-hardware/rte/ board
MIT License
7 stars 3 forks source link

Design of replacing flash.sh script with Python script reusing OSFV lib #82

Open macpijan opened 3 weeks ago

macpijan commented 3 weeks ago

We do already have some Python module: https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/src/osfv/libs/rte.py which already implements what we need in this script: https://github.com/3mdeb/RteCtrl/pull/22/files

We should review both of them, and propose if/how we can achieve code reuse, by implementing local flash.py script on RTE, using the same module, simply using localhost address as rte_ip.

This script may reside in osfv-scripts repo.

macpijan commented 3 weeks ago

Maybe there is no need for another script, and we could somehow use osfv_cli directly on the localhost.

I think resolving this https://github.com/Dasharo/osfv-scripts/issues/57 and possible also adding one or two more features, could help to achieve this.

We need to first take a look at possible solutions and decide on something.

DaniilKl commented 1 day ago

It could be done by installing osfv_cli on RTE and using localhost as RTE IP. But osfv_cli as well as RteCtrl will need to be extended for WP features and for using custom flashrom parameters in the way flash.sh does. Currently it is not implemented. We can also consider using SSH or REST API to do the work, though IMO REST API is more suitable to use with localhost, but in that case, osfv_cli will need to be modified to use flashrom via REST API, because currently it is using SSH.

And, most importantly, the issue https://github.com/Dasharo/osfv-scripts/issues/57, must be solved, otherwise this issue could not be solved.