Closed Jaymassena closed 10 years ago
We throw out foursquare places that don't have a phone number because we have no way to dedupe them.
Sorry, I saw the later line of code that let through places with 500 checkins even if they didn't have a phone number and missed the earlier line:
// We dedupe on phone number
if (isFullVenue && !(venue.contact && venue.contact.phone)) return
// popularity filter
if (isFullVenue) {
if (!(venue.stats && venue.stats.checkinsCount)) return
if (venue.stats.checkinsCount < 20) return
if ((venue.stats.checkinsCount < 500) && !(venue.contact && venue.contact.phone)) return
}
Closing not a bug for now.
The foursquare call always returns four places: Vashon Island Ferry Terminal 2064646400 Blake Island State Park 3609028844 Port Vashon 2066504182 Metro Bus Stop #46769 2065533000
I used an oauth token generated for my own foursquare account.
The call returns places that are missing from the places/near call including the following and others. Some are getting filtered out by the checkin filter but others look to me like they should make it.
Southworth Ferry Terminal
{ "categories" : [ { "icon" : { "prefix" : "https://ss1.4sqi.net/img/categories_v2/travel/ferry_pier_", "suffix" : ".png" }, "id" : "4e74f6cabd41c4836eac4c31", "name" : "Pier", "pluralName" : "Pier", "primary" : true, "shortName" : "Pier" } ], "contact" : { }, "hereNow" : { "count" : 0, "groups" : [ ], "summary" : "0 people here" }, "id" : "4b4fca1bf964a5207a1527e3", "location" : { "address" : "11564 SE State Highway 160", "cc" : "US", "city" : "Southworth", "country" : "United States", "distance" : 58, "formattedAddress" : [ "11564 SE State Highway 160", "Southworth, WA 98386" ], "lat" : 47.5120703345804, "lng" : -122.49734401702881, "postalCode" : "98386", "state" : "WA" }, "name" : "Southworth Ferry Terminal", "referralId" : "v-1404150289", "specials" : { "count" : 0, "items" : [ ] }, "stats" : { "checkinsCount" : 3094, "tipCount" : 3, "usersCount" : 1031 }, "url" : "http://www.wsdot.wa.gov/ferries/vesselwatch/terminaldetail.aspx?terminalid=20", "verified" : false }
Tillicum Village (on nearby Blake Island)
Southworth grocery (Right at entrance to ferry lot)