search

3meters / proxibase

Patchr web service
1 stars 0 forks source link

/suggest should return mixed list of users and patches #405

Closed georgesnelling closed 8 years ago

georgesnelling commented 8 years ago

Current have /suggest/patches and /suggest/users implemented on the server but /suggest/users it is not exposed at the client. We could let /suggest return a mixed list of both users and patches. Patches have locations, and users have area, but all other fields are the same.

Jaymassena commented 8 years ago

I believe the client does use suggest/users when auto-suggesting users to send a share or invite to.

georgesnelling commented 8 years ago

Oh good. Do you think the generic search box should return users mixed in with patches?

Jaymassena commented 8 years ago

I think we should capture that as a feature candidate. With a mixed list, there is work to do. Some icon or sectioning to differentiate users from patches and probably a fast way to filter the list to just one or the other (pretty typical for this kind of stuff).

georgesnelling commented 8 years ago

I went ahead and implemented this at the server. You can implement the client side if you like. If you just send /suggest?input=massena and don't set any of the parameters users, patches, or places, we will default to sending back places and users. I confirmed from the logs that none of the existing clients were calling this endpoint this way, so there should be no impact on existing clients.

Jaymassena commented 8 years ago

Makes sense to me.