3meters / proxibase

Patchr web service
1 stars 0 forks source link

Service dies during password reset call #432

Closed Jaymassena closed 7 years ago

Jaymassena commented 7 years ago

Here is the log:

==== Req: 37098792, from: ::ffff:75.172.120.128, worker: 4, on: Sun, 31 Jul 2016 17:13:30 GMT
post /v1/user/pw/reset
{ installId: '69b86d4b-1ba9-4202-a9eb-3d42653a54d3',
  password: '******',
  token: '91b658909abd643a29cbccd8fe5027086be0e54e' }
mail sent
{ to: [ 'sos@3meters.com' ],
  subject: 'Worker 4 died Sun, 31 Jul 2016 17:13:30 GMT',
  result: { message: 'success' } }
Worker 5 process 13187
Jaymassena commented 7 years ago

I confirmed that password reset works fine as long as the installId exists. Should installId be more of a soft reference than a strong reference? Across the different handsets and android OS versions, there is a bewildering matrix of behavior when it comes to unique device ids. We can do our best and still easily hit something that unexpectedly reset the install id to something new for a given install.

georgesnelling commented 7 years ago

Fixed with 4.2.1. Bogus installIds on password reset are now ignored.