search

3o14r473 / qmenu

Manage QubesOS via dmenu.
GNU General Public License v3.0
3 stars 3 forks source link

QubesOS-contrib #7

Open fepitre opened 2 years ago

fepitre commented 2 years ago

Hello, @3o14r473 ! Thank you again for contributing this package to @QubesOS-contrib. We've noticed that you've done further development work on this package, and we'd like to make your work available to Qubes users. Would you please submit an update pull request at your earliest convenience? Thank you!

3o14r473 commented 2 years ago

Thank you very much for reaching out to me @fepitre.

I got sidetracked and made some major improvements to this little project just recently. I wanted to make sure everything works before submitting an update but it took some time.

The old codebase was a convoluted mess so I pushed my newest iteration by force (git push --force) to "relaunch" this project on a clean foundation to build upon. Everything should be more readable now, qmenu-vm has been separated into sensible and way more readable pieces and the git log is now clean and useful.

So before I submit an update pull request I'll have to ask, because I "relaunched" this project by doing a very dirty forced push, if it would be more appropriate to delete the old QubesOS-contrib/qubes-qmenu and fork 3o14r473/qmenu anew.

I apologize for this mess. From now on I will keep tabs on this project and be more mindful when updating it in the future!

Lastly, please do me a favor and check the contents of qmenu.spec.in and other files in the BUILD folder and add missing instructions to the %install and %files sections, whenever you have the time for that. Feel free to move files where needed.

fepitre commented 2 years ago

@3o14r473 Great to hear you are still working on it. I'm currently waiting for a feedback of @marmarek on how I should proceed in this case. Probably the previous repo is going to be named with an "old" prefix. At least, we need your version to be greater or equal the current one. I will review your work in all the cases :). What could be useful when this is will be closed to be a fork again, a PR from your dev branch against your master branch would be helpful for review and to prepare it's new location in contrib.

3o14r473 commented 2 years ago

@fepitre Alright, I'll be checking up on it regularly. Sorry again for the extra work I put you through. Great, thank you :)

Okay, I merged dev and master.