3ofcoins / chef-cookbook-hostname

Chef cookbook to set node's hostname and FQDN.
MIT License
41 stars 90 forks source link

Boolean attribute that allows bypassing of the hosts IP to the hostsfile. #23

Closed brenttheisen closed 9 years ago

xamebax commented 10 years ago

Hi, could you explain why this would be useful to have?

brenttheisen commented 10 years ago

Sure. Without something like this the chef recipe will always write a /etc/hosts entry for the node it runs on. You can configure the IP it puts in there so it isn't always the loopback IP but I don't want to have to specify that for every node. Instead, I already have a internal DNS server that will resolve the node's hostname for me so I just want this chef recipe to set the hostname without writing an /etc/hosts entry for it.

mpasternacki commented 10 years ago

The use case is good; desired behaviour depends on /etc/resolv.conf and its search setting or the internal DNS resolving unqualified names, but I'd say this is outside this cookbook's scope. The changes are not ready to merge, though. Please:

When that is done, I'll merge the change and release new version.

brenttheisen commented 10 years ago

Deleted old branch and pushed new one with changes as requested. I can use my fork for the foreseeable future so no need to push a release on my account.

brenttheisen commented 10 years ago

Rebased to get rid of merge conflicts.

xamebax commented 10 years ago

Hi, very sorry for not responding for so long. The Travis build is failing here (old gems I guess), but I fixed it on develop. If I'm not mistaken, when you merge develop in, everything should be working fine and dandy.

mburns commented 9 years ago

I'm generally positive towards this change, but there has bit some bitrot due to inaction. I'm closing this in favor of #44