3ofcoins / chef-cookbook-hostname

Chef cookbook to set node's hostname and FQDN.
MIT License
41 stars 90 forks source link

Ensure sysctl kernel.hostname set correctly #55

Closed mmrwoods closed 7 years ago

mmrwoods commented 8 years ago

Code to set kernel.hostname in /etc/sysctl.conf didn't allow for a temporary change of hostname that is later reverted. For example, if the hostname is originally set to foo.example.com, is then changed to bar.example.com and later reverted to foo.example.com, the last kernel.hostname entry in /etc/sysctl.conf will remain bar.example.com, because the guard condition looks for any match in /etc/sysctl.conf

Fixed by editing existing entries where applicable and updating the guard condition to find and match on the last kernel.hostname line

mburns commented 7 years ago

👍