Closed vadikmash closed 2 years ago
I've highly simplified Image component, so you should probably take a closer look and decide, whether it was a right thing to do.
That’s great, thank you! gatsby-image
didn’t work well with gatsby-plugin-no-javascript
which was the reason we needed a custom image implementation. gatsby-plugin-image
seems to work with gatsby-plugin-no-javascript
perfectly, so this is a really nice improvement.
gatsby-plugin-image
seems to work withgatsby-plugin-no-javascript
perfectly, so this is a really nice improvement.
Gah, no, it actually doesn’t. In Safari, images stay invisible.
I suggest to revert back to a custom <Image>
implementation. Gatsby’s one still brings more issues than it solves :/
@vadikmash Heya – let me know if you need any help with finishing this! (Don’t hesitate to reach out if you feel stuck.)
Re: webp in Safari – I’m actually comfortable with using webp there. Safari supports it as of v14 (and macOS Big Sur), and I don’t care much about older OSes/versions.
Hey! I've updated new code to be compatible with gatsby-image-plugin
.
Good news. It looks like GatsbyImage
implementation works correctly in Safari now! All images are visible.
Soo.. I've fixed all the issues. Had to apply some inline styles to GatsbyImage
component, which were the only way to properly style image container and image itself according to documentation (replacing div
container element with span
did not help). Hope that this solution is acceptable :)
This is wonderful ⚡ Thank you!
Closes #58.
Fully migrated to
gatsby-plugin-image
. Everything seems to look exactly as before, except for new beautifully animated image loading. I've highly simplifiedImage
component, so you should probably take a closer look and decide, whether it was a right thing to do.