search

3rd-Eden / node-hashring

hashring is a consistent hashing algorithm for Node.js that is compatible with libketama and python's hash_ring package
MIT License
350 stars 61 forks source link

Use a different regex for nan package version #21

Closed rohiniwork closed 10 years ago

rohiniwork commented 10 years ago

Hi,

Could you please update this https://github.com/3rd-Eden/node-hashring/blob/master/package.json#L28

Current version of nan is 1.1.0 and your package cannot use it.

3rd-Eden commented 10 years ago

Is 1.1.0 backwards compatible with 1.0.0?

On Tuesday, May 27, 2014 at 10:10 PM, rohiniwork wrote:

Hi, Could you please update this https://github.com/3rd-Eden/node-hashring/blob/master/package.json#L28
Current version of nan is 1.1.0 and your package cannot use it.

— Reply to this email directly or view it on GitHub (https://github.com/3rd-Eden/node-hashring/issues/21).

rohiniwork commented 10 years ago

I think it is, except that it has gotten nicer with syntax and also warns for NanSymbol being deprecated. Please give it a try and use the latest nan, it has support for lower versions of gcc.