search

3rd-Eden / node-hashring

hashring is a consistent hashing algorithm for Node.js that is compatible with libketama and python's hash_ring package
MIT License
350 stars 61 forks source link

update nan to 2.0.x to support iojs 3.0 #36

Closed XadillaX closed 8 years ago

XadillaX commented 8 years ago

Nan 1.9.x not support iojs 3.0.

So I updated nan to 2.0.x and modified some *.cc code.

3rd-Eden commented 8 years ago

Pulled #35 instead.

3rd-Eden commented 8 years ago

But thanks for your contribution <3

XadillaX commented 8 years ago

but that pr dropped c++ addon, will it be ok?

3rd-Eden commented 8 years ago

There's a pretty intensive distribution test: https://github.com/3rd-Eden/node-hashring/blob/master/tests/distribution.test.js which compares the output of this module against the output of ketema and the HashRing library. The output is still identical after merging the pull request so there is no change in the distribution of the hashring.

XadillaX commented 8 years ago

i mean something like benchmark?

3rd-Eden commented 8 years ago

There's no benchmark as far as I'm aware of, sorry.

3rd-Eden commented 8 years ago

But it would be fairly easy to generate of course as both versions are now in npm.