support constructing with no arguments, and removing last server

[jmar777]

There are currently failures when constructing a new hashring with no arguments, as well as when a final remaining server is removed. This pull request simply adds some handling (and test cases) for these situations.

[3rd-Eden]

Thanks a lot for the pull request & fixes!

[jmar777]

Wow, that was... fast. Thanks! Any chance you could do a version bump and npm publish? :)

[3rd-Eden]

Gonna do that in a couple of hours when I get home and run some final tests on it.

On Thursday, May 3, 2012 at 4:52 PM, Jeremy Martin wrote:

There are currently failures when constructing a new hashring with no arguments, as well as when a final remaining server is removed. This pull request simply adds some handling (and test cases) for these situations.

You can merge this Pull Request by running:

git pull https://github.com/jmar777/node-hashring zero-arguments

Or you can view, comment on it, or merge it online at:

https://github.com/3rd-Eden/node-hashring/pull/6

-- Commit Summary --

• support constructing with no arguments, and removing last server

-- File Changes --

M lib/hashring.js (6) M tests/hashring.test.js (26)

-- Patch Links --

https://github.com/3rd-Eden/node-hashring/pull/6.patch https://github.com/3rd-Eden/node-hashring/pull/6.diff

---

Reply to this email directly or view it on GitHub: https://github.com/3rd-Eden/node-hashring/pull/6

[jmar777]

Awesome, thanks again!