search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
898 stars 137 forks source link

OS parser added #1

Closed dvv closed 13 years ago

dvv commented 13 years ago

Please, consider pulling

TIA, --Vladimir

3rd-Eden commented 13 years ago

Looks good to me, but wouldn't we want android, and iOS ( instead of ipad ) detection aswel?

dvv commented 13 years ago

Sure. Wouldn't you validate OS detection?

3rd-Eden commented 13 years ago

Sure, it would be nice to have. Anyways I'll merge and update the repo tonight with your changes. We can always add iOS, android etc based detections later.

dvv commented 13 years ago

Thanks! You might also want to update .pretty() to honor OS printing; I haven't snooped in it to not break tests

3rd-Eden commented 13 years ago

I did some small changes to the code, so it can re-use the parser function for the user agents. This way we don't need to create new functionality to parse operating systems and printing of the values.

This also makes it easier to do operation system based parsing.