Avoid concurrency issues when updating regexps.js

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org

MIT License

897 stars 137 forks source link

Avoid concurrency issues when updating regexps.js #100

Closed klall closed 7 years ago

klall commented 7 years ago

Ensure that the generated data for regexps.js is stored in a temporary file first and only after renamed to regexps.js. This ensures that there are no concurrency issues. Specifically this aims to address the issue seen in https://github.com/3rd-Eden/useragent/issues/30

klall commented 7 years ago

Thanks I've updated it with your comments.

klall commented 7 years ago

Just a friendly reminder to do another review.

thanks

3rd-Eden commented 7 years ago

it will be in the next release of useragent.

3rd-Eden commented 7 years ago

alive in 2.1.12