3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Device parsing fails for certain mobile devices #112

Open ksunda200 opened 7 years ago

ksunda200 commented 7 years ago

Example ua: "Mozilla/5.0 (Linux; Android 7.0; Moto G (4) Build/NPJS25.93-14-4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 Mobile Safari/537.36"

useragent.device returns Device { family: 'Moto $2', major: 'G (4)', minor: '0', patch: '0' }

mrbar42 commented 5 years ago

Chipping in some more examples

Mozilla/5.0 (Linux; Android 6.0; Moto G Play Build/MPI24.241-15.3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.124 Mobile Safari/537.36
{family: "Moto $2", major: "G Play", minor: "0", patch: "0"}

Mozilla/5.0 (Linux; Android 7.0; LG-H870I Build/NRD90U; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/67.0.3396.87 Mobile Safari/537.36
{family: "LG-$2", major: "H870I ", minor: "0", patch: "0"}

Mozilla/5.0 (Linux; Android 7.0; Moto G (5) Build/NPPS25.137-15-11; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/63.0.3239.111 Mobile Safari/537.36
{family: "Moto $2", major: "G (5)", minor: "0", patch: "0"}

Mozilla/5.0 (Linux; Android 7.0; HUAWEI NMO-L31 Build/HUAWEINMO-L31) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.0 Mobile Safari/537.36
{family: "HUAWEI $2", major: "NMO-L31", minor: "0", patch: "0"}

Mozilla/5.0 (Linux; Android 6.0.1; MotoG3-TE Build/MPDS24.107-56-1-21; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/60.0.3112.107 Mobile Safari/537.36
{family: "Moto$2", major: "G3-TE", minor: "0", patch: "0"}

live example here

Duplicate of https://github.com/3rd-Eden/useragent/issues/63