search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Headless Chrome version not parsed correctly #118

Open aclar48 opened 6 years ago

aclar48 commented 6 years ago

Using a newer version of Chromium in headless mode, useragent does not report the version correctly.

Agent { family: 'HeadlessChrome', major: '0', minor: '0', patch: '0', source: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/64.0.3240.0 Safari/537.36' }

mgol commented 6 years ago

uap-core had incomplete regex, I made a PR to fix that in https://github.com/ua-parser/uap-core/pull/263, it's just been merged.

I think now useragent just needs to pull the latest uap-core.

mmermerkaya commented 6 years ago

This works in useragent 2.3.0.