search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

feat: add callback support to updater function #127

Open knksmith57 opened 6 years ago

knksmith57 commented 6 years ago

Remove unused (and obviated) refresh param from updater() function and add optional cb param.

cb is an errback (Error-First Callback) and, when supplied, will be invoked with the result of parse().

This unblocks work on #31.

knksmith57 commented 6 years ago

@jstewmon did you want to take a look at this?

jstewmon commented 6 years ago

LGTM

knksmith57 commented 6 years ago

@3rd-Eden any chance you could take a look at this? Super small PR with test coverage + jsdoc updates.

thanks!