search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

4th+ parts of version discarded #32

Closed jmhnilbog closed 10 years ago

jmhnilbog commented 11 years ago

Chrome version numbers go beyond major.minor.patch, like so:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1521.3 Safari/537.36

...but useragent doesn't seem to allow the retrieval of the '.3' in the example above.

3rd-Eden commented 11 years ago

@jmhnilbog That's true, but this is only true for Chrome. As far as I'm aware, knowing this 3 doesn't really add any benefits especially for chrome which auto updates so rapidly. Is there a particular reason on why you need this?

jmhnilbog commented 11 years ago

I've got no immediate need. It's more interesting as a bit of information lost in parsing. (I imagine that any Chrome version increment that tiny containing anything that needed to be tested for would almost immediately be updated.)

3rd-Eden commented 11 years ago

Yes, ok, the biggest problem is the all of the parsing regular expressions are only build for 3 parts of version numbers (major, minor, patch) introducing another field would be huge task, so I don't know if that's worth the effort.

3rd-Eden commented 10 years ago

Decided it's just not worth the effort atm as it's an edge case only for chrome.