search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Add android support to is method #40

Closed msemenistyi closed 10 years ago

msemenistyi commented 10 years ago

Currently module lacks first class support of android so it's not a straightforward task to determine whether device used is android or not.

3rd-Eden commented 10 years ago

Cannot merge automatically, it probably conflicts with your previous pull request. Could you rebase?

msemenistyi commented 10 years ago

Should I include both commits? From my point of view property a of should lib is not a function and not a correct syntax was used. Its docs say that type checking shopuld be done this way: https://github.com/visionmedia/should.js#type-assertions Am I missing something?

msemenistyi commented 10 years ago

@3rd-Eden can i expect this to be merged and published to npm?

3rd-Eden commented 10 years ago

@msemenistyi I'll merge, but I can't release master yet as tests are still failing. I still got to look at what broke.

msemenistyi commented 10 years ago

@3rd-Eden they were broken due to this commit https://github.com/visionmedia/should.js/commit/d9a80982266d3f5f7183bd814a03fd8f7fe52e88 they are now fixed and you should avoid a('type') syntax, I guess.

msemenistyi commented 10 years ago

ping @3rd-Eden. do you consider publishing it to npm?

3rd-Eden commented 10 years ago

@msemenistyi My problem is that the current master's test are failing so I can't push it out until I get time to fix it.

3rd-Eden commented 10 years ago

Hmm, never mind, it seems to be passing again. How odd. Anyways I'll push it out right away.