search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Android 4.4.2 incorrectly detected Chrome 30.0.0 #46

Closed mwbrooks closed 9 years ago

mwbrooks commented 10 years ago

Problem

On an Android 4.4.2 device, the .toAgent() function returns Chrome 30.0.0 instead of Android.

Reproducible on

Argh, user-agents! :)

3rd-Eden commented 9 years ago

It's now detected as chrome mobile instead of just chrome. It should not be android as it's not an android browser but a chrome browser. The operating system is correctly parsed as android:

Browser: 

{ family: 'Chrome Mobile',
  major: '30',
  minor: '0',
  patch: '0',
  source: 'Mozilla/5.0 (Linux; Android 4.4.2; Nexus 5 Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/30.0.0.0 Mobile Safari/537.36' }

OS:

 family: 'Android',
  major: '4',
  minor: '4',
  patch: '2' }

So i'm going to close this issue with the assumption that it's all working as intended now but thanks for reporting <3

mwbrooks commented 9 years ago

Cool, thanks for the clarification @3rd-Eden!