search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Problem with capitalization #49

Closed sebsn closed 9 years ago

sebsn commented 10 years ago

I use the library to parse huge amounts of useragents. Sometimes I get lists of decapitalized (ie all small letters) useragents. The Parser doesn't pick them up. Is there a way to add that functionality?

3rd-Eden commented 10 years ago

Should be fairly easy to solve in the library by adding a 'i', in the new RegExp creation: https://github.com/3rd-Eden/useragent/blob/master/lib/update.js#L106

But I don't know if this would lead to false positives in the whole ua detection

3rd-Eden commented 9 years ago

Closing this, all changes and regexp updates should be made against regexp database that we use, not this module.

( https://github.com/tobie/ua-parser/blob/master/regexes.yaml )