search

3rd-Eden / useragent

Useragent parser for Node.js, ported from browserscope.org
MIT License
897 stars 137 forks source link

Moved semver to dependencies from devDependencies #61

Closed sheepsteak closed 9 years ago

sheepsteak commented 9 years ago

semver is required at runtime but is in the devDependencies. At the moment it's not installed with npm install.

3rd-Eden commented 9 years ago

That's why i've mentioned separately: https://github.com/3rd-Eden/useragent#adding-more-features-to-the-useragent in the README. It's not a dependency that is used by the "core" parse but just by optional features that not everybody uses so it didn't make sense to add them as a dependency of the project.

sheepsteak commented 9 years ago

You're right, sorry. I scanned through the README again before posting but didn't see that.

So if it's optional how about moving it into the optional dependencies? Then in the README state the fact that npm install --no-optional will install the core features only?