search

3rd-Eden / versions

Versions, A small module for creating a flexible CDN application
204 stars 13 forks source link

configuration should contain comments #6

Closed 3rd-Eden closed 11 years ago

3rd-Eden commented 11 years ago

The versions.json should be able to be commented. It's not that hard to remove comments from a JSON file before we parse it. It would increase the readability of these formats.

juliangruber commented 11 years ago

or make it a version.js that needs to export an object

3rd-Eden commented 11 years ago

Yes, that might be a good idea as well. I'll add support for that.

juliangruber commented 11 years ago

And text editors gonna hate you too

3rd-Eden commented 11 years ago

version.js files are already supported if you do a versions.read('/path/to/versions.js') as versions#read uses Node's module system to read and parse JSON files. Just gonna add an extra test against it and make sure that it also tests for javascript files that do not export.