while running app getting following error

[kumar0608]

Traceback (most recent call last): File "app.py", line 11, in from githubapp import GitHubApp, LDAPClient, TEST_MODE, CRON_INTERVAL File "/Users/sravula/Downloads/saml-ldap-team-sync-2.0/githubapp/init.py", line 27, in TEST_MODE = strtobool(os.environ.get('TEST_MODE', False)) File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/util.py", line 301, in strtobool val = val.lower() AttributeError: 'bool' object has no attribute 'lower' OSXSRAVUMBP15:saml-ldap-team-sync-2.0 sravula$

[primetheus]

@kumar0608 can you try changing https://github.com/github/saml-ldap-team-sync/blob/master/githubapp/__init__.py#L27 to put quotes around False and see if that fixes it?

TEST_MODE = strtobool(os.environ.get('TEST_MODE', 'False'))

[primetheus]

I have a PR opened for this in #45

[kumar0608]

HI Jared,

sorry to bother you again, can you please advise about this error?

File "/Users/sravula/Downloads/ldap2/saml-ldap-team-sync/githubapp/core.py", line 36, in load_env app.config['GITHUBAPP_ID'] = int(os.environ['APP_ID'])

already i have this value in the .env file

On Sun, Jul 5, 2020 at 12:13 PM Jared Murrell notifications@github.com wrote:

I have a PR opened for this in #45 https://github.com/github/saml-ldap-team-sync/pull/45

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/github/saml-ldap-team-sync/issues/44#issuecomment-653927422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMZET2VM4XQYCZ7EAAT3J3R2DGHNANCNFSM4OQHJMSA .

[kumar0608]

HI Jarad,

we are getting the above error

what is the purpose of these below env variables?

WEBHOOK_SECRET=development

GitHub App ID

APP_ID=12345

Private Key Path

PRIVATE_KEY_PATH=.ssh/team-sync.pem

On Sun, Jul 5, 2020 at 11:03 PM Pragnya Ravula ravula06@gmail.com wrote:

HI Jared,

sorry to bother you again, can you please advise about this error?

File "/Users/sravula/Downloads/ldap2/saml-ldap-team-sync/githubapp/core.py", line 36, in load_env app.config['GITHUBAPP_ID'] = int(os.environ['APP_ID'])

already i have this value in the .env file

On Sun, Jul 5, 2020 at 12:13 PM Jared Murrell notifications@github.com wrote:

I have a PR opened for this in #45 https://github.com/github/saml-ldap-team-sync/pull/45

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/github/saml-ldap-team-sync/issues/44#issuecomment-653927422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMZET2VM4XQYCZ7EAAT3J3R2DGHNANCNFSM4OQHJMSA .

[primetheus]

@kumar0608 can you tell me how you installed the requirements for this, and how you are running it?

[primetheus]

the variables will be filled in with the data from creating the GitHub App... You can find more information about how to create a GitHub App here: https://developer.github.com/apps/building-github-apps/creating-a-github-app/

[kumar0608]

yeah i configured app in github enterprise and provided APP details in the .env file

Thanks Sridhar

On Mon, Jul 6, 2020 at 9:51 AM Jared Murrell notifications@github.com wrote:

the variables will be filled in with the data from creating the GitHub App... You can find more information about how to create a GitHub App here: https://developer.github.com/apps/building-github-apps/creating-a-github-app/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/github/saml-ldap-team-sync/issues/44#issuecomment-654351017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMZETYE3OTTYJLILUUMLE3R2H6IJANCNFSM4OQHJMSA .

[kumar0608]

if you have 5 min time, will you be able to help on this?

Thanks Sfidhar

On Mon, Jul 6, 2020 at 11:46 AM Pragnya Ravula ravula06@gmail.com wrote:

yeah i configured app in github enterprise and provided APP details in the .env file

Thanks Sridhar

On Mon, Jul 6, 2020 at 9:51 AM Jared Murrell notifications@github.com wrote:

the variables will be filled in with the data from creating the GitHub App... You can find more information about how to create a GitHub App here: https://developer.github.com/apps/building-github-apps/creating-a-github-app/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/github/saml-ldap-team-sync/issues/44#issuecomment-654351017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMZETYE3OTTYJLILUUMLE3R2H6IJANCNFSM4OQHJMSA .

[primetheus]

I'm closing this one, as the original issue has been solved in #45. The present conversation revolves around #46