Issue with load_custom_map LDAP sync

3rd-party-integrations / github-team-sync

Sync GitHub teams to groups in Active Directory, LDAP, Okta, OneLogin or AzureAD when using any authentication method for GitHub.

MIT License

201 stars 67 forks source link

Issue with load_custom_map LDAP sync #78

Closed benhocker closed 3 years ago

benhocker commented 3 years ago

In the example syncmap.yml.example, it is referring to the LDAP group by a key of ldap: but in the load_custom_map method it is looking for a key of directory:. Which is the proper key and I'll submit a PR for fixing the code or documentation?

Once I updated my syncmap.yml to look like this, the syncs started working:

---
mapping:
  - github: team1
    directory: ldapgroup1
  - github: team2
    directory: ldapgroup2

primetheus commented 3 years ago

Thanks @benhocker! We implemented new backends and this was an oversight in testing.

benhocker commented 3 years ago

Looks good. Thanks!