search

3rd / image.nvim

🖼️ Bringing images to Neovim.
MIT License
1.1k stars 47 forks source link

Image still shown when switching to a different tmux session #198

Open shurensha opened 3 months ago

shurensha commented 3 months ago

How to reproduce:

  1. setup two tmux sessions (not windows)
  2. minimal config on first to display image
  3. prefix+L to navigate to second
  4. image is still displayed

Possibly related to: #106

tmux 3.4 kitty 0.35.2 nvim v0.10.0 image.nvim 61c76515cfc3cdac8123ece9e9761b20c3dc1315

set -gq allow-passthrough on
set -g visual-activity off

screenshots

session 'notes'

image

session 'image_nvim'

image

edte commented 3 months ago

same problem, and also same nvim version and tmux version

shurensha commented 3 months ago

same problem, and also same nvim version and tmux version

try my PR if it fixes it on your end

Jendker commented 2 months ago

Same issue on wezterm. The PR does not fix this, unfortunately. Please let me know if I should open a separate issue for wezterm.

3rd commented 2 months ago

can you try this branch? https://github.com/3rd/image.nvim/tree/pr/199 branch is pr/199 it's not merged yet

Jendker commented 2 months ago

Yes, it still happens on the pr/199 branch. I am using the default image.nvim config.

davidfmatheson commented 1 month ago

Same problem, tried with pr/199 branch, to no avail.

3rd commented 1 month ago

This was fixed by @maxbol in https://github.com/3rd/image.nvim/pull/221 :pray:

maxbol commented 1 month ago

My PR was against the 199 branch, not sure if you noticed, but I think you might have merged it into that and then closed that branch @3rd ? 😀

3rd commented 1 month ago

ah crap, sorry about that

davidfmatheson commented 1 month ago

Woohoo, this worked. Much appreciated.

KilinW commented 3 weeks ago

@davidfmatheson May I ask you how does it worked? Mine still got a overlapped when I switch between tabs or sessions. I'm already on the 88e9693 commit now.

davidfmatheson commented 3 weeks ago

@davidfmatheson May I ask you how does it worked?

I ran Lazy and updated the plugin, navigated to a markdown file with an image referenced, moved the cursor to that line, saw the image, left the cursor there and brought up my mix session picker (<leader>s for me), navigated to a different session, the image went away. It also goes away if I switch windows within a session.

I would note the image stayed visible on the session picker screen, but progress!

3rd commented 3 hours ago

I think it's the best we can do for now, other than hiding the images on focus lost, but that would not be pleasing either :joy: