search

3rdparty / eventuals-grpc

C++ asynchronous interface for gRPC based on https://github.com/3rdparty/eventuals.
Apache License 2.0
20 stars 5 forks source link

Added code format check of `.proto` files #24

Closed ArthurBandaryk closed 3 years ago

ArthurBandaryk commented 3 years ago

Added check_style_proto in the tools directory. It's a simple bash script which is run in the check_format_code.yaml action.

ArthurBandaryk commented 3 years ago

Also tested check_style_proto script locally. Was playing with correct format, then added some format errors and made some lines exceed 80 characters. The results and test.proto file are on the screen below. Screen Shot 2021-09-30 at 9 40 15 PM Screen Shot 2021-09-30 at 9 41 04 PM Screen Shot 2021-09-30 at 9 41 37 PM

ArthurBandaryk commented 3 years ago
  1. Need advise from Ben to choose how we would like to check .proto files: using prototool or clang-format.
  2. For now ,as you could remember, jidicula's clang-format-action doesn't check if line[i] > 80 chars. So actually I'm thinking about to remove this action and to base on the Ben's script tools/pre-commit. Your thoughts guys?