search

3rdparty / eventuals-grpc

C++ asynchronous interface for gRPC based on https://github.com/3rdparty/eventuals.
Apache License 2.0
20 stars 5 forks source link

Fix builds by checking out submodules #58

Closed CodingCanuck closed 2 years ago

CodingCanuck commented 2 years ago

Fixes #56.

CodingCanuck commented 2 years ago

Builds are still running for 3 minutes now: https://github.com/3rdparty/eventuals-grpc/runs/4695374734?check_suite_focus=true https://github.com/3rdparty/eventuals-grpc/runs/4695374736?check_suite_focus=true

But gosh do they look fixed, since they're not failing after 4s with "No WORKSPACE file found" errors like in https://github.com/3rdparty/eventuals-grpc/runs/4608427962?check_suite_focus=true

So I suspect this fixes things.

CodingCanuck commented 2 years ago

Builds are still running for 3 minutes now: https://github.com/3rdparty/eventuals-grpc/runs/4695374734?check_suite_focus=true https://github.com/3rdparty/eventuals-grpc/runs/4695374736?check_suite_focus=true

But gosh do they look fixed, since they're not failing after 4s with "No WORKSPACE file found" errors like in https://github.com/3rdparty/eventuals-grpc/runs/4608427962?check_suite_focus=true

So I suspect this fixes things.

Confirmed that this fixes builds, since the ubuntu build & test has finished building: https://github.com/3rdparty/eventuals-grpc/runs/4695374736?check_suite_focus=true (ubuntu tests are still running, and mac build is still running: https://github.com/3rdparty/eventuals-grpc/runs/4695374734?check_suite_focus=true )

CodingCanuck commented 2 years ago

Formatting Check

@while-false could you please remove the old check_code_format action to be able to merge this PR?

Arthur, can you say more about this? Do we need to delete https://github.com/3rdparty/eventuals-grpc/blob/main/.github/workflows/check_format_code.yml ? You mention it's an old check: is there something newer that replaces it, like https://github.com/3rdparty/eventuals-grpc/blob/main/tools/pre-commit ? If so, how does that get run?

(Gorm's out this week so I can try to send out more fixes, or we can bundle everything into this PR to make it a "get things working" generic fix)

CodingCanuck commented 2 years ago

Formatting Check

@while-false could you please remove the old check_code_format action to be able to merge this PR?

Arthur, can you say more about this? Do we need to delete https://github.com/3rdparty/eventuals-grpc/blob/main/.github/workflows/check_format_code.yml ? You mention it's an old check: is there something newer that replaces it, like https://github.com/3rdparty/eventuals-grpc/blob/main/tools/pre-commit ? If so, how does that get run?

(Gorm's out this week so I can try to send out more fixes, or we can bundle everything into this PR to make it a "get things working" generic fix)

I just filed https://github.com/3rdparty/eventuals-grpc/issues/59 to discuss the format check being seemingly broken: let's discuss there.

CodingCanuck commented 2 years ago

Formatting Check

@while-false could you please remove the old check_code_format action to be able to merge this PR?

Arthur, can you say more about this? Do we need to delete https://github.com/3rdparty/eventuals-grpc/blob/main/.github/workflows/check_format_code.yml ? You mention it's an old check: is there something newer that replaces it, like https://github.com/3rdparty/eventuals-grpc/blob/main/tools/pre-commit ? If so, how does that get run? (Gorm's out this week so I can try to send out more fixes, or we can bundle everything into this PR to make it a "get things working" generic fix)

I just filed #59 to discuss the format check being seemingly broken: let's discuss there.

I think #59 is fixed now, so this PR should now auto-merge once this second round of builds completes (probably in ~30 minutes).

ArthurBandaryk commented 2 years ago

Formatting Check

@while-false could you please remove the old check_code_format action to be able to merge this PR?

Arthur, can you say more about this? Do we need to delete https://github.com/3rdparty/eventuals-grpc/blob/main/.github/workflows/check_format_code.yml ? You mention it's an old check: is there something newer that replaces it, like https://github.com/3rdparty/eventuals-grpc/blob/main/tools/pre-commit ? If so, how does that get run? (Gorm's out this week so I can try to send out more fixes, or we can bundle everything into this PR to make it a "get things working" generic fix)

I just filed #59 to discuss the format check being seemingly broken: let's discuss there.

I think #59 is fixed now, so this PR should now auto-merge once this second round of builds completes (probably in ~30 minutes).

Wow, exactly! check_format_code is an unexisting action which never ends:) Since I have no permissions to update branch protection rules I asked Gorm:) Anyway ty for dealing with this!