search

3rdparty / eventuals-grpc

C++ asynchronous interface for gRPC based on https://github.com/3rdparty/eventuals.
Apache License 2.0
20 stars 5 forks source link

check_code_format / Formatting Check doesn't seem to work #59

Closed CodingCanuck closed 2 years ago

CodingCanuck commented 2 years ago

See discussion on https://github.com/3rdparty/eventuals-grpc/pull/58 : the "check_code_format / Formatting Check" check seems to perpetually have the status "Expected — Waiting for status to be reported". It seems broken.

CodingCanuck commented 2 years ago

Note that we seem to have 3 Formatting Check checks: 2 that work (one push, one pull), and 1 that doesn't: Screen Shot 2022-01-03 at 11 53 26 AM

CodingCanuck commented 2 years ago

I think that the problem here is that we had a branch protection rule configured to required a "check_code_format" check that didn't actually run.

I've updated the branch protection rules to instead treat the working formatting check rules as required, and to not expect the non-existent version of the formatting check: Screen Shot 2022-01-03 at 12 04 48 PM