3rdparty / eventuals-grpc

C++ asynchronous interface for gRPC based on https://github.com/3rdparty/eventuals.
Apache License 2.0
20 stars 5 forks source link

Use `borrowed_ptr` in `ServerBuilder::RegisterService` #83

Open rjhuijsman opened 2 years ago

rjhuijsman commented 2 years ago

To avoid usage mistakes like that in https://github.com/3rdparty/eventuals-grpc/issues/81 it would be helpful to have an API that prevents "holding it wrong".

Our current hypothesis is that we could have ServerBuilder::RegisterService take a borrowed_ptr instead of a raw pointer.