search

3rf / codecoroner

tool for detecting unused functions and variables in Go source code
http://kyleerf.com
141 stars 22 forks source link

Fix compilation #11

Closed cristim closed 7 years ago

cristim commented 7 years ago

I tried to compile it but it failed out of the box, apparently prog.CreateTestMainPackage() no longer supports a variadic pkgs argument.

I set it to the first item from the slice and it seemed to work for me.

3rf commented 7 years ago

Thank you for doing this! Unfortunately, this change causes some TestMain-related tests to fail, so I'll have to do some more digging to make sure the implications of the change to prog still let the analysis cover multiple packages.

I will have time to really look into this during the Thanksgiving holiday later this week.

Thanks again! Always happy to see interest in this tool :)

cristim commented 7 years ago

Can this be closed?