search

3rf / codecoroner

tool for detecting unused functions and variables in Go source code
http://kyleerf.com
142 stars 22 forks source link

This package is broken pending a move to the new callgraph pkgs #5

Closed 3rf closed 9 years ago

3rf commented 9 years ago

Hopefully I will get some free time to update this before the end of May 2015. If you're feeling squirrelly, you can get it to compile by checking out an old version of the oracle package.

ernestoalejo commented 9 years ago

Do you know a specific commit that works correctly with the code?

ernestoalejo commented 9 years ago

OK, I figured it out. The last oracle commit you can use that works correctly is: https://github.com/golang/tools/commit/68b5f7541d840b07800dc21d83ebdaa8ca8a771f

3rf commented 9 years ago

Thanks for your interest, Ernesto! This commit removes callgraph support: https://github.com/golang/tools/commit/b28839e4bdc90af193b3e38f473e5f9175158b41

So this one should still work if you use it directly: https://github.com/golang/tools/commit/68b5f7541d840b07800dc21d83ebdaa8ca8a771f

Ultimately this change is going to make things much better--having a real set of packages for callgraphs is much nicer than the hack I was doing! But until we move to the new callgraph packages, things are borked when relying on "go get" :/

3rf commented 9 years ago

Ahh beat me to it by a few seconds, nice :+1:

ernestoalejo commented 9 years ago

@3rf At the same time :laughing: haha Thanks. I use this tool from time to time to fix the accumulated issues over time in the code so the temporary checkout it's not so bad in the meantime this gets fixed.

3rf commented 9 years ago

For anyone still tracking this project, I'll be spending a few internal hackathon days next week getting this project back on track. Good things ahead :beers:

mblair commented 9 years ago

:trophy:

3rf commented 9 years ago

Moved to the callgraph/rta package (https://godoc.org/golang.org/x/tools/go/callgraph/rta) since it seemed best suited for dead code detection. Tests passing and it seems to be working swimmingly on the mongo-tools and evergreen.

My next task is a complete overhaul of the README, then some other usability enhancements. Please let me know if things are still broken on y'alls end.